Fix Hwloc parse error in test/runtests.jl (includes #676) #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing [sources] sections for SciMLJacobianOperators in NonlinearSolveBase and NonlinearSolveFirstOrder - Add missing dependencies and [sources] section for SCCNonlinearSolve (NonlinearSolve, NonlinearSolveBase, NonlinearSolveFirstOrder) - Update all inter-repo dependency compat entries to current versions - Bump minor version for all packages: - NonlinearSolve: 4.10.0 -> 4.11.0 - BracketingNonlinearSolve: 1.3.0 -> 1.4.0 - NonlinearSolveBase: 1.14.0 -> 1.15.0 - NonlinearSolveFirstOrder: 1.7.0 -> 1.8.0 - NonlinearSolveHomotopyContinuation: 0.1.5 -> 0.2.0 - NonlinearSolveQuasiNewton: 1.8.0 -> 1.9.0 - NonlinearSolveSciPy: 1.0.0 -> 1.1.0 - NonlinearSolveSpectralMethods: 1.3.0 -> 1.4.0 - SCCNonlinearSolve: 1.4.0 -> 1.5.0 - SciMLJacobianOperators: 0.1.8 -> 0.2.0 - SimpleNonlinearSolve: 2.7.0 -> 2.8.0 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Only add [sources] section for test dependencies, not new deps 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
The PR incorrectly bumped sublibrary versions to their next versions (what they would be after the PR merges) instead of their current latest release versions. This commit reverts all sublibrary versions to their correct current release versions: - BracketingNonlinearSolve: 1.4.0 → 1.3.0 - NonlinearSolveBase: 1.15.0 → 1.14.0 - NonlinearSolveFirstOrder: 1.8.0 → 1.7.0 - NonlinearSolveHomotopyContinuation: 0.2.0 → 0.1.5 - NonlinearSolveQuasiNewton: 1.9.0 → 1.8.0 - NonlinearSolveSciPy: 1.1.0 → 1.0.0 - NonlinearSolveSpectralMethods: 1.4.0 → 1.3.0 - SCCNonlinearSolve: 1.5.0 → 1.4.0 - SciMLJacobianOperators: 0.1.9 → 0.1.8 - SimpleNonlinearSolve: 2.8.0 → 2.7.0 Also updated the corresponding compat bounds in the main Project.toml file.
Add try-catch blocks around Hwloc.num_physical_cores() and Hwloc.num_virtual_cores() calls to handle cases where Hwloc fails (e.g., on some CI environments like macOS aarch64). This fixes the ArgumentError: input string is empty or only contains whitespace error that occurs when Hwloc functions fail and return unexpected values. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hwloc.num_physical_cores()andHwloc.num_virtual_cores()calls with appropriate fallbacksProblem
The CI fails with:
This happens when
Hwloc.num_physical_cores()orHwloc.num_virtual_cores()fail on certain systems, causing the parse function to receive an invalid string.Solution
Wrapped the Hwloc calls in try-catch blocks with sensible fallback values (0 workers for physical cores, 1 thread for virtual cores) to ensure the tests can still run even when Hwloc is not available or fails.
Test plan
Fixes the error from https://github.com/SciML/NonlinearSolve.jl/actions/runs/16882652406/job/47822213017?pr=676
🤖 Generated with Claude Code